Conversation
ref https://linear.app/ghost/issue/DES-1292/offer-creation-primary-action-is-a-tiny-non-obvious-link The copy link is the primary action when editing an offer but was buried as a tiny link below the offer code input at the bottom of the form. Moved the offer code field to sit right below the offer name and added an inline copy link button for better discoverability. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only layout/styling changes in the offer edit modal; no changes to saving logic or API interactions. > > **Overview** > Makes the *offer link copy* action more prominent when editing an offer by moving the `Offer code` field directly under `Offer name` and rendering a visible inline `Copy link` button within the input when a code is present. > > Updates the `Offer code` field hint styling to show a truncated URL preview and removes the previous small link-style copy control embedded in the hint area. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3ba5367. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
no issue
- Fixed `createOffer` helper using stale page state after archiving an offer — the code captured button visibility before archiving but used those values after, causing it to click "Manage offers" when the page
had changed to "Add offer". Now re-checks live page state after the archive step.
- Replaced unreliable `waitForLoadState('networkidle')` with a concrete tier visibility assertion in the comped upgrade test — `networkidle` never resolves reliably due to Ghost Admin's background polling
- Added portal trigger visibility waits and increased Stripe webhook timeout to 30s after checkout redirects in both upgrade tests
This test-only change should have no user impact. This replaces the following Should.js assertions with `node:assert`: - `.should.be.a.Date` - `.should.be.a.Function` - `.should.be.a.String` - `.should.be.aboveOrEqual` - `.should.be.rejectedWith` - `.should.be.true` - `.should.containDeep` - `.should.endWith` - `.should.have.length` - `.should.have.size` - `.should.not.be.undefined` - `.should.not.equal` - `.should.not.have.keys` - `.should.not.throwError`
ref https://linear.app/ghost/issue/DES-1279/announcement-toast-is-cut-off-by-expanded-sidebar - The announcement banner was cut off on smaller screens and squeezed in between menu items - Dark mode wasn't supported in banners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )